-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unexpected result for api/rss/atom query that combines tag and user facets #2540
Comments
This is a result of this change: 7a9c8c7. Reverting back to a default AND rather than a default OR should be relatively straightforward. Say the word and it's done. |
Yes please! |
I think that's a terrible idea. OR is a much more sensible default, to me. I propose that instead of switching to AND you should remove the default order. Either the stream view can specify the order or the a boosted created/updated facet could be used to consider a time/relevance trade-off. In general, though, I think search APIs are much more user friendly when they return partial matches. Imagine if you got no results in a Google search every time you had a combination of words that didn't appear. Instead, Google shows you partial matches and tells you which words are missing. |
If you removed the default order you would still get 1242 matches for https://hypothes.is/api/search?tags=wisdom&user=judell but the first one would be the one with the tag. |
In all of the API uses cases I'm aware of, default AND is the expected behavior. That's true also for interactive use cases I'm aware of, actually. So for our users, explicit search is the primary need. To address the secondary need (fuzzy search) I'd like to start by surfacing our query facets explicitly in the UI, with inline prompts -- particularly for the any (wildcard) facet. That one arguably should offer an explicit choice between ANDing and ORing multiple terms. |
I would consider whether these are just different APIs. To me, the stream search, as a user and developer, is much more useful if it's lenient. That's why I made that change. If there's a need for a strict AND of the facets, maybe it's a different endpoint. |
As I already said, Google is default OR. Elasticsearch itself defaults to OR for query string searches. If you're going to claim that every API you know does the opposite it might be good to name even one of them, @judell. But I think the real issue is that filter/fetch is different intent than search. |
"But I think the real issue is that filter/fetch is different intent than True. The word "filter" better describes what the API and interactive users On Mon, Oct 12, 2015 at 11:32 AM, Randall Leeds notifications@github.com
|
"the word" |
any progress here? i have a teacher wanting to view individual user contributions within a tag, but has not been able to... |
@jeremydean This is fixed but not deployed yet, so you'll see it fixed the next time we do a deploy (watch the releases channel in Slack) |
https://hypothes.is/api/search?tags=wisdom -> 8
https://hypothes.is/api/search?tags=wisdom&uri=https://posts.postlight.com/this-is-postlight-fe49148b014 -> expect 1, got 1
https://hypothes.is/api/search?tags=wisdom&user=judell -> expect 1, got 1242
(https://hypothes.is/api/search?user=judell -> 1235)
The text was updated successfully, but these errors were encountered: