Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New annotations not moved to current group when switching groups #3380

Closed
robertknight opened this issue May 29, 2016 · 1 comment · Fixed by hypothesis/client#8
Closed

New annotations not moved to current group when switching groups #3380

robertknight opened this issue May 29, 2016 · 1 comment · Fixed by hypothesis/client#8

Comments

@robertknight
Copy link
Member

Steps to reproduce

  1. Create a new annotation whilst a group A is selected, but don't publish it
  2. Switch groups

Expected behaviour

Annotation should move to new group

Actual behaviour

Annotation does not move to new group.

Browser/system information

Firefox 48

Additional details

  • Behavior should be the same whether or not the annotation has any text
  • This looks like a regression with the new threading implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify annotation component by removing duplicated state hypothesis/client
2 participants
@robertknight @nickstenning