Fix #2965 (1/N) - Fix redundant calls to onEditText() in markdown editor component #3541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where onEditText() would be called unnecessarily when the markdown editor lost focus. Simplify the code by just listening for the 'input' event, which all our target browsers support.
Current coverage is 74.39%@@ master #3541 diff @@
==========================================
Files 132 133 +1
Lines 4707 5210 +503
Methods 0 0
Messages 0 0
Branches 527 642 +115
==========================================
+ Hits 3426 3876 +450
- Misses 1213 1248 +35
- Partials 68 86 +18
|
robertknight
changed the title
|
👍 For anyone else looking at this: http://caniuse.com/#feat=input-event |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first in a set of PRs to fix #2965 and #3380 which are ultimately caused by certain state for annotations being duplicated and getting out of sync.
This fixes an issue where onEditText() would be called unnecessarily
when the markdown editor lost focus.
Simplify the code by just listening for the 'input' event, which all our
target browsers support.