Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PDF plugin #1775

Merged
merged 1 commit into from
Dec 9, 2014
Merged

Update PDF plugin #1775

merged 1 commit into from
Dec 9, 2014

Conversation

csillag
Copy link
Contributor

@csillag csillag commented Dec 8, 2014

... to 18d8f72a (typed-packaging branch),
which brings support for the PDF.js version
shiping with FF35.

(This PR simply just brings to H the changes merged
in https://github.com/hypothesis/annotator/pull/88.)

... to 18d8f72a (typed-packaging branch),
which brings support for the PDF.js version
shiping with FF35.
@csillag
Copy link
Contributor Author

csillag commented Dec 8, 2014

... as described in hypothesis/vision#135

@csillag
Copy link
Contributor Author

csillag commented Dec 8, 2014

So. FF35 Beta is now out.
Which means that for the users who are on FF beta channel, our PDF support is broken ...
... until we merge and deploy this.

Can we? (All proposed changes already reviewed, discussed, and cleaned up in https://github.com/hypothesis/annotator/pull/88.)

tilgovi added a commit that referenced this pull request Dec 9, 2014
@tilgovi tilgovi merged commit a95beff into master Dec 9, 2014
@tilgovi tilgovi deleted the update-pdfjs-support branch December 9, 2014 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants