Remove browserify-pipe #2183
Merged
Remove browserify-pipe #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For @nickstenning |
tilgovi
force-pushed
the
vanilla-browserify
branch
from
fc51e35
to
60e3195
Compare
This is totally safe unless there is another input filter before browserify, but let's just say that's not allowed because it simplifies things nicely to not have this extra script.
tilgovi
force-pushed
the
vanilla-browserify
branch
from
60e3195
to
5a7086d
Compare
|
I'm going with this. As an input filter, browserify should be acting on each file independently. The only issue would be if another filter was wrapped inside browserify. I think that's got to be considered incorrect usage. If you need to filter things at that point, the browserify transform stack is the place to do it. |
|
Retroactive 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is totally safe unless there is another input filter before
browserify, but let's just say that's not allowed because it
simplifies things nicely to not have this extra script.