Use Node v4.3 on Travis #3022
Closed
Use Node v4.3 on Travis #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Node v4 for consistency with what we use to build the production assets in the Docker build and also to enable some ES2015 goodness. Travis does not support multiple languages in the 'language' field, so non-default Node versions need to be installed with nvm as part of the install process. Rebuilding node-sass was needed to get a version of the native binding that matched the Node version, even when running with a clean cache. I'm not clear at the moment on why this was necessary.
robertknight
force-pushed
the
travis-node-upgrade
branch
from
37ccdcf
to
7787d1f
Compare
|
Merged as 7ae8c78. The rebuild wasn't necessary after clearing the Travis cache, and I've moved the installation of Node to before the first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Node v4 for consistency with what we use to
build the production assets in the Docker build
and also to enable some ES2015 goodness in Gulp scripts (eg. template strings)
Travis does not support multiple languages
in the 'language' field, so non-default Node
versions need to be installed with nvm as
part of the install process.
Rebuilding node-sass was needed to get a version
of the native binding that matched the Node version,
even when after clearing the cache for the branch. I'm not clear
at the moment on why this was necessary.