Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hound run jscs #3023

Merged
merged 1 commit into from
Feb 26, 2016
Merged

Make hound run jscs #3023

merged 1 commit into from
Feb 26, 2016

Conversation

seanh
Copy link
Contributor

@seanh seanh commented Feb 25, 2016

No description provided.

@robertknight
Copy link
Member

Before merging this, I think it would be a good idea to do a one-off fix across the codebase using jscs --fix to correct many of the existing stylistic inconsistencies and avoid cluttering future PRs with unrelated changes to existing code.

@nickstenning
Copy link
Contributor

@robertknight these two things (merging this and running an autofixer on our code) can happen in either order. In the meantime, Hound will AIUI only comment on files changed in a PR, so hopefully it won't be too noisy.

nickstenning added a commit that referenced this pull request Feb 26, 2016
@nickstenning nickstenning merged commit e4298d1 into master Feb 26, 2016
@nickstenning nickstenning deleted the add-jscs-to-hound-config branch February 26, 2016 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants