Support inline form editing for Notifications settings form #3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 76.51% (diff: 91.66%)@@ master #3782 diff @@
==========================================
Files 150 149 -1
Lines 5562 5647 +85
Methods 0 0
Messages 0 0
Branches 618 637 +19
==========================================
+ Hits 4315 4321 +6
- Misses 1175 1252 +77
- Partials 72 74 +2
|
In preparation for implementing more complex controllers such as the one that will support inline form editing, add a `Controller` base class which provides shared functionality: - Setting the state of the controller and updating the DOM to reflect that - Getting references to the various elements within the controlled element which the controller needs to interact with * Add Controller base class and rewrite several existing controllers to use it * Simplify tests using functionality from the Controller base class
Implement a generic enhancement for forms which enables inline editing, triggered by forms rendered with deform that have the `data-inline-editing` attribute set to a truthy value. Inline editing is initially enabled only for the 'Edit Profile' form. The other forms will require some additional features to enable inline editing.
For XHR form submissions, we assume that the client code takes care of displaying an appropriate success indicator.
… inputs are changed For use in the Account Notifications form, add support for automatically submitting the form when toggling a checkbox item or selecting a radio input.
robertknight
force-pushed
the
inline-form-editing-notifications
branch
from
a83d0f8
to
3bc6931
Compare
|
I'm closing this for the moment while I explore an alternative approach to implementing inline form editing. See #3774 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3774
Implement inline editing for the Notifications settings form. This comes in two parts: