Add virtualenv to install steps for macOS #4865
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4865 +/- ##
=======================================
Coverage 96.61% 96.61%
=======================================
Files 387 387
Lines 21404 21404
Branches 1214 1214
=======================================
Hits 20680 20680
Misses 610 610
Partials 114 114Continue to review full report at Codecov.
|
This step was previously only listed under the Ubuntu instructions, but is also needed on macOS. Assuming that Python + pip has been installed with Homebrew, following the suggested steps, sudo is not required.
Use Apple's current name for their OS.
Remove a reference to a long-outdated version of Ubuntu from the install docs.
h currently requires an old version of Elasticsearch.
robertknight
force-pushed
the
update-venv-docs
branch
from
0f78c29
to
4714fe0
Compare
|
These seem like straightforward, helpful changes. LGTM. 👍 |
|
I'll take that as an approval. |
|
adding the 'pip install -U pip virtualenv' corrects the first problem i encountered when installing the env, is it worth adding the instructions for removing python 3 which caused the first build of h to fail or at least checking |
|
Hi @dawariley - h should be fully usable with Python 3 for local development once #4842 is merged, so this should cease to be a problem. |
This addresses some issues with h's installation docs noticed while getting @dawariley set up with an h development environment:
The main issue we ran into is that
brew install pythonnow installs Python 3 aspythonrather than Python 2. The same issue already applies to some Linux distros. For that, I suggest we get #4838 and #4842 merged so that a local dev install works under Python 3.