Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about target selectors to our reporting annotation table #7985

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

jon-betts
Copy link
Contributor

@jon-betts jon-betts commented Jun 8, 2023

For:

This adds info about target selectors, which will allow us to work out if things are page notes / highlights etc.

Note! This will take some care to release, as we need a full re-index of the annotations, which will probably take a while.

Open questions

  • Is there any value in storing the number of target_selectors vs a boolean?

Testing notes

SELECT * FROM report.annotations
  • You should see the different booleans set
  • Run fast_recreate
  • Run refresh
  • Hopefully nothing asplodes

DO NOT MERGE

When this is ready, it will take a bit of timing to run the create from scratch. This took 45 minutes before and could easily take longer now. When that is done we should do the fast recreate and finally an update.

This should be done so as to avoid the normal update window for H + LMS + Report.

@jon-betts jon-betts added WIP Do not merge technical enabler Technical work that facilitates further work labels Jun 8, 2023
@jon-betts jon-betts self-assigned this Jun 8, 2023
@jon-betts jon-betts force-pushed the report-anno-targets branch 2 times, most recently from b00e02f to 6136125 Compare June 8, 2023 13:45
@jon-betts jon-betts added WIP and removed WIP labels Jun 12, 2023
We intend to use whether we have targets to work out what type of annotation
we have. We can use this to differentiate between replies, page notes and
others.
Copy link
Member

@marcospri marcospri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's see how long the from scratch process takes this time.

@jon-betts jon-betts merged commit b357bf8 into main Jun 13, 2023
5 of 6 checks passed
@jon-betts jon-betts deleted the report-anno-targets branch June 13, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical enabler Technical work that facilitates further work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants