Pass SENTRY_ENVIRONMENT through to frontend
#8799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Propagate the Sentry environment name through to the frontend code that initializes the Sentry JS SDK.
robertknight
commented
Jul 8, 2024
| @@ -27,6 +27,7 @@ def add_renderer_globals(event): | |||
| if "h.sentry_dsn_frontend" in request.registry.settings: | |||
| event["frontend_settings"]["sentry"] = { | |||
| "dsn": request.registry.settings["h.sentry_dsn_frontend"], | |||
| "environment": request.registry.settings["h.sentry_environment"], | |||
There was a problem hiding this comment.
h.sentry_environment is currently always set. It takes its value from the SENTRY_ENVIRONMENT env var with a default of dev.
There was a problem hiding this comment.
We have (in h-prod):
SENTRY_ENVIRONMENT
and
ENV
both with value a value of prod 👍
We might want to look at combine those at some point, outside of scope here.
|
Alejandro is away this week, so I'm tagging BE folks for review. |
marcospri
approved these changes
Jul 8, 2024
| @@ -27,6 +27,7 @@ def add_renderer_globals(event): | |||
| if "h.sentry_dsn_frontend" in request.registry.settings: | |||
| event["frontend_settings"]["sentry"] = { | |||
| "dsn": request.registry.settings["h.sentry_dsn_frontend"], | |||
| "environment": request.registry.settings["h.sentry_environment"], | |||
There was a problem hiding this comment.
We have (in h-prod):
SENTRY_ENVIRONMENT
and
ENV
both with value a value of prod 👍
We might want to look at combine those at some point, outside of scope here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate the Sentry environment name through to the frontend code that initializes the Sentry JS SDK.