Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install dependencies pip-sync-faster in tox's commands_pre instead of command #5158

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Mar 7, 2023

Moving pip-sync-faster execution from tox's commands to commands_pre, so that it gets executed even when commands is overwritten via --run-command.

@acelaya acelaya requested a review from seanh March 7, 2023 14:02
@seanh seanh self-assigned this Mar 7, 2023
@seanh
Copy link
Collaborator

seanh commented Mar 7, 2023

Thanks! Yeah I think this is already how it works in the cookiecutter so I think this works. Can't immediately see any problems with this. Let's give it a try

@acelaya
Copy link
Contributor Author

acelaya commented Mar 7, 2023

I think this is already how it works in the cookiecutter so I think this works

True! https://github.com/hypothesis/cookiecutters/blob/b8a2828818d884e612a16f59a33ddaf1012dd7ec/_shared/project/tox.ini#L90

@acelaya acelaya merged commit 0f445bf into main Mar 7, 2023
@acelaya acelaya deleted the deps-commands-pre branch March 7, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants