Support editing assignment from launch error dialog

[robertknight]

Add an "Edit assignment" link to the launch error dialog, if the user is an instructor and assignment editing is enabled. This makes it possible to fix certain errors by editing the assignment, when previously it would have required re-creating the assignment.

See #5163 (comment) for testing notes.

[robertknight]

We discussed the UI design in Slack and have consensus to add an "Edit assignment" button to this dialog, which is always present if the user is an instructor. This should

• Provide a more obvious call-to-action when appropriate
• Avoid potential problems where a developer adds a new error message to this component but forgets to add a link to the edit assignment view

[robertknight]

Following some discussion, the UI has been changed to expose the option to edit an assignment via a link at the bottom of the dialog, which is always available. This makes the behavior more predictable, regardless of what error occurred.

To test the dialog, you can either configure a new assignment with an invalid configuration (eg. pick an empty group set) or apply the diff below to trigger the dialog on any assignment launch:

diff --git a/lms/static/scripts/frontend_apps/components/BasicLTILaunchApp.tsx b/lms/static/scripts/frontend_apps/components/BasicLTILaunchApp.tsx
index ae14a625..3e06b9f3 100644
--- a/lms/static/scripts/frontend_apps/components/BasicLTILaunchApp.tsx
+++ b/lms/static/scripts/frontend_apps/components/BasicLTILaunchApp.tsx
@@ -177,6 +177,9 @@ export default function BasicLTILaunchApp() {
    * Fetch the URL of the content to display in the iframe
    */
   const fetchContentURL = useCallback(async () => {
+    setErrorState('error-fetching');
+    return false;
+
     if (!viaAPICallInfo) {
       // If no "callback" URL was supplied for the frontend to use to fetch
       // the URL, then the backend must have provided the Via URL in the

[lyzadanger]

Following some discussion, the UI has been changed to expose the option to edit an assignment via a link at the bottom of the dialog, which is always available. This makes the behavior more predictable, regardless of what error occurred.

This UI is looking better to me! Perhaps underline the "Edit assignment"?

[robertknight]

This added comment is unrelated to the other changes in this PR.

[lyzadanger]

extraActions here is rendered, when present, after any cancel button, when present. Are there situations in which we could end up with:

<cancel button> [Edit assignment] <retry button>

or

<cancel button> [Edit assignment]

? Perhaps extraActions could come first? Also perhaps you have already thought through these cases...

[robertknight]

For the current use case in LaunchErrorDialog, there is no Cancel option, so the issue doesn't arise. I am not sure which will make the most sense for future use cases. When "Edit assignment" had a more button-like appearance it seemed sensible to put it next to the primary action. With the revised link-like appearance, that makes less sense. I'll move it to the left of "Cancel" for now, but I expect we might need to revisit in future.

[acelaya]

Looks good to me, but it's worth addressing Lyza's comment, I think: https://github.com/hypothesis/lms/pull/5163/files#r1137071669

[robertknight]

Thanks for the feedback. I have moved extraActions to the left of the OK/Cancel buttons in the dialog for the moment, although this doesn't affect this particular dialog as there is no "Cancel" action available. OK for me to get this merged @acelaya?

[acelaya]

OK for me to get this merged @acelaya?

@robertknight yes! Go for it