Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix guideline issues #54

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Fix guideline issues #54

merged 3 commits into from
Jan 26, 2024

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Jan 26, 2024

Part of #40

This PR fixes the issues reported by the WordPress plugins team on their latest review.

  • They reported an incorrect license used in the License field, and that a GPL-compatible one has to be used. I updated it from BSD to BSD-2-Clause, just in case only the identifier is wrong, as BSD appears as a GPL-compatible license.
    However, I have asked them to clarify if this is the probelm.
  • I documented the integration with a third party, as we load the embed.js script from https://hypothes.is/embed.js
    This is allowed, but it needs to be explicitly noted in the readme.txt file.
    I also added links to our terms of service and privacy policy.
  • I added a unique Hypothesis PHP namespace to our code, to avoid symbol name collisions with the global namespace that WordPress uses for its own internal API.

Copy link
Member

@robertknight robertknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a query about what "integrate with the Hypothesis annotations API" refers to.

README.md Show resolved Hide resolved
readme.txt Outdated Show resolved Hide resolved
@acelaya acelaya merged commit 6fa9c8a into main Jan 26, 2024
6 checks passed
@acelaya acelaya deleted the fix-guideline-issues branch January 26, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants