Add strided copy function for ParVectors #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liruipeng
reviewed
Jan 18, 2024
src/seq_mv/vector_device.c
Outdated
| #if defined(HYPRE_USING_CUDA) || defined(HYPRE_USING_HIP) | ||
| auto counting_iter = thrust::make_counting_iterator(0); | ||
|
|
||
| HYPRE_THRUST_CALL( transform_if, counting_iter, counting_iter + size, v_data, v_data, |
There was a problem hiding this comment.
This call has the complexity of O(size). There should be a more efficient implementation of O(size/stride), I assume.
There was a problem hiding this comment.
Yes, done in b507d9c
I've also generalized the new code to accept different strides for the source and destination arrays
liruipeng
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
hypre_ParVectorStridedCopyfor performing a strided copy operation from a source data array to the data array of a hypre_Vector structure (x->data).The source and destination arrays can be accessed with different strides.
A strided copy means that elements are copied from the source to the destination at regular stride intervals.
To be used in MGR