Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use predefined bs_size #120

Merged
merged 1 commit into from Jun 2, 2018
Merged

Use predefined bs_size #120

merged 1 commit into from Jun 2, 2018

Conversation

arrelid
Copy link
Contributor

@arrelid arrelid commented Apr 6, 2018

Before this change, this wouldn't run on macOS.

@arrelid
Use predefined bs_size
b2c2594 
Before this change, this wouldn't run on macOS.
@StefanScherer
Copy link
Member

I use flash on macOS, so I wonder why this change is needed.

@jppurcell9
Copy link

I just ran into this myself. The error only occurs when pv is not installed. The change is needed because macOS expects a lowercase m in the block size argument to dd (1m instead of 1M). The else branch here is hit when pv is not installed, and has the block size hard-coded instead of using the bs_size var.

@StefanScherer
Copy link
Member

Thanks for clarification. LGTM. Thanks @arrelid

@StefanScherer StefanScherer merged commit 17040af into hypriot:master Jun 2, 2018
@jppurcell9 jppurcell9 mentioned this pull request Jun 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arrelid @StefanScherer @jppurcell9