Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

focuscurrentorlast: scroll affects previous window #3227

Closed
woojiq opened this issue Sep 9, 2023 · 0 comments · Fixed by #3229
Closed

focuscurrentorlast: scroll affects previous window #3227

woojiq opened this issue Sep 9, 2023 · 0 comments · Fixed by #3229
Labels
bug Something isn't working

Comments

@woojiq
Copy link

woojiq commented Sep 9, 2023 •
edited
Loading

Hyprland Version

91e28bb

Bug or Regression?

Bug

Description

$altMod = ALT
bind = $altMod, Tab, focuscurrentorlast

If I press Alttab and don't move the mouse afterwards and try to scroll, it scrolls the previous window and not the current window. I need to move cursor a little (with touchpad or mouse) to make it work as expected. Watch the video below to understand better.
I've looked at the code a bit and I can guess that it can be fixed here: https://github.com/hyprwm/Hyprland/blob/main/src/managers/input/InputManager.cpp#L1256C1-L1276C2

How to reproduce

2023-09-09.13-43-40.mp4

Crash reports, logs, images, videos

No response
@woojiq woojiq added the bug Something isn't working label Sep 9, 2023
@woojiq woojiq changed the title focuscurrentorlast: mouse uses previous window if not move cursor focuscurrentorlast: mouse scrolls previous window if not move cursor Sep 9, 2023
@woojiq woojiq changed the title focuscurrentorlast: mouse scrolls previous window if not move cursor focuscurrentorlast: scroll affects previous window Sep 9, 2023
memchr added a commit to memchr/Hyprland that referenced this issue Sep 9, 2023
@memchr
refactor: replace lambdas with CKeybindManager::switchToWindow
8f9aedb 
moves `switchToWindow` lambdas to a single private method
`CKeybindManager::switchToWindow()`.

fixes hyprwm#3227, as a by-product of the mouse motion simulation at the end
of `CKeybindManager::switchToWindow()`.
@memchr memchr mentioned this issue Sep 9, 2023
Merged
vaxerski pushed a commit that referenced this issue Sep 10, 2023
@memchr
refactor: replace lambdas with CKeybindManager::switchToWindow (#3229)
f7f70c9 
moves `switchToWindow` lambdas to a single private method
`CKeybindManager::switchToWindow()`.

fixes #3227, as a by-product of the mouse motion simulation at the end
of `CKeybindManager::switchToWindow()`.
@LanderMoerkerke LanderMoerkerke mentioned this issue Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: replace lambdas with CKeybindManager::switchToWindow memchr/Hyprland
1 participant
@woojiq