refactor: replace lambdas with CKeybindManager::switchToWindow

[memchr]

Abstract

There are 3 byte to byte identical and one spiritually identical lambdas switchToWindow in KeybindManager.cpp. They will surely come back to haunt us one day as bugs often breed in repetitive code.

Changes

• moves switchToWindow lambdas to a single private method CKeybindManager::switchToWindow().

• fixes focuscurrentorlast: scroll affects previous window #3227, as a by-product of the mouse motion simulation at the end of CKeybindManager::switchToWindow().

[memchr]

Other notes

There is currently a bug similar to #3227 in listener_mapWindow(), where scrolling affects the previous window instead of the mapped window if the mapped window was focused. simulateMouseMovement() may not be sufficient to fix this bug as there is an edge case: If the cursor is exactly in the middle of the borders of the previous window and the mapped window, the previous window will get the focus when simulateMouseMovement() is called.

So that bit remains untouched, along with the fact that this patch is primarily a refactor, and the fix for #3227 is a side effect.

[woojiq]

I can confirm that this solves my problem.
@memchr thanks for the quick response ❤️

[vaxerski]

thanks!