groupbar fixes #2630
Merged
groupbar fixes #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Jul 3, 2023
|
ready to merge to me, the stretching issue is to be fixed separately, I can already see why it happens |
|
PHEAD has already defined in that function as the HEAD of the target group, SHEAD was the the head of the source group. |
ItsDrike
added a commit
to ItsDrike/hyprland-dwindle-autogroup
that referenced
this pull request
Jul 22, 2023
Hyprland has updated some of the core functions related to groupping windows in PR: hyprwm/Hyprland#2630 Specifically, the CWindow::insertWindowIntoGroup was updated to no longer automatically make the newly inserted window the group's head, allowing to insert windows without the group auto-focusing them. With that, the CKeybindManager::moveIntoGroup (dispatcher) function was then updated to adhere to the change in insertWindowIntoGroup and to make the inserted widow the group's head from there. It's probably possible to utilize the insertWindowIntoGroup without making the inserted window the group's head in a more clever way, however for now, this commit just changes our logic in groupCreate function to fully replicate the moveIntoGroup for each dwindle child node window. This means we're still doing what we were doing before, that is to insert a window, make it the group head, repeat for each dwindle child and at the end make the original group head the head again. The reason this fix doesn't simply skip making each of the nodes a group head is that without it, the layout doesn't seem to properly recognize that the window should no longer be shown, and while this probably can be addressed by replicating some of the CWindow::setGroupCurrent function's behavior, for now, that's a task for later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes multiple groupbar decoration issues:
probably more but I don't remember
Dwindle Layout as been tested and seems stable and working as intended.
Master Layout seem to work as well, but has been less tested and I'm less familiar with how it works.
Known issues:
Still haven't found the cause of the focused window groupbar not getting correctly updated when there are multiple groups open side by side (text gets streched) (was already on main branch). Probably related to multiple groupbar damage issues open here.
There is also an unusual animation the first time opening a window that was in a group after merging it with another group (only on Master Layout). Still haven't found the cause. (was already on main branch as well)
Probably ready to merge, but a bit of testing would be good
Closes: