fix(layout): remove focusWindow calls from onWindowCreatedTiling

[memchr]

Abstract

Remove calls to focusWindow() from all implementations of onWindowCreatedTiling()

Bug fixed

commit 05047f6 (#2630) introduced a bug where the active workspace incorrectly changes when using silent workspace methods or rules if the target workspace contains an unlocked group.

Current behaviour

When

• using the moveActiveToWorkspaceSilent dispatcher to move the active window to a target workspace
• or using the [workspace silent] rules to create a window in the target workspace

and the target workspace contains an unlocked group, the active workspace incorrectly changes to the target workspace instead of remaining in the current workspace as intended (not silent).

Expected behaviour

Active workspace should remain the same when moveActiveToWorkspaceSilent or [workspace silent] are used, regardless the content of target workspace.

Changes

Upon initial static analysis and debugging results, I respectfully suggest that all direct or indirect callers of onWindowCreatedTiling() appear to be calling focusWindow() themselves, or implying that their operand is active within the context. Therefore, the following lines may be redundant or betray the intention of their direct or indirect callers.

Hyprland/src/layout/DwindleLayout.cpp

Line 344 in 1a6f961

g_pCompositor->focusWindow(pWindow);

Hyprland/src/layout/MasterLayout.cpp

Line 123 in 1a6f961

g_pCompositor->focusWindow(pWindow);

Thus they are removed in this patch.

Please let me know if I have overlooked any significant details or drawn any erroneous assumptions in my conclusions.

[vaxerski]

right, it's not the layout's job to manage focus anyways.