Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GTK portal as fallback #3469

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Add GTK portal as fallback #3469

merged 1 commit into from
Oct 2, 2023

Conversation

gnusenpai
Copy link
Contributor

On systems with xdg-desktop-portal 1.17+, the GTK portal is not started by default and cannot be used (even if started manually). This should fix issues on such systems like: theming/cursors being incorrect, not being able to open the file picker, and being unable to open links from other applications (#3258).

Users who wish to use an alternative portal (e.g. for QT-based dialogs) should still be able to do so by overriding this with their own preferences in ~/.config/xdg-desktop-portal/hyprland-portals.conf. This PR just makes the portals act like they did before xdg-desktop-portal 1.17.

In my brief testing, this doesn't cause any regressions for those on xdg-desktop-portal 1.16.

needed for XDP 1.17+ since the fallback to the GTK portal was removed
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vaxerski vaxerski merged commit 778bdf7 into hyprwm:main Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants