Avoid rounding errors in window position on dwindle #3524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Oct 8, 2023
|
Just realized it's only for the dwindle layout but I've seen this issue on master as well. edit: The issue on master layout seems way more complex. I had moderate success with |
FakeMichau
changed the title
pdamianik
pushed a commit
to pdamianik/Hyprland
that referenced
this pull request
Oct 10, 2023
* Avoid rounding errors in window position * Fix naming scheme * Fix unwanted window movement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Avoids rounding errors in window position and size which can result in wallpaper being visible between windows when it shouldn't. Simply gives second children the rest of the space instead of calculating again.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Should resolve #3511
Is it ready for merging, or does it need work?
It's ready