-
-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persistent workspace rule #3530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good, thanks!
* add persistent flag to workspace rules * get rid of unused ws->indestructible flag
This works great but now |
Not sure, i only use r+-1. Maybe I'll test it this weekend. |
Not sure if this is intentional, but e+-1 and m+-1 wont navigate to a persistent workspace if its empty. It would be cool if it did, or if you could make it so. If the workspace aren't empty e+-1 and m+-1 would loop around from the last workspace to the first. r+-1 makes a new workspace, then a new one and so on instead of looping, which is fine but a different workspace experience. |
I'm sorry for not having enough time to address this quickly, i'll try to use e+-1 and m+-1 which I'm not using right now, and then I'll take a look at the code. I already started, but it's complex and I don't want to risk breaking anything. |
I am using multiple monitors and keybinds for m+1 e+1. @hariseldon78 for navigation of workspaces on a monitor, would a method to reorder them in a stack be of use ? (it can be named something else if there is a more appropriate name) Something like : config : Workspace stack should be relative to a monitor. Personnaly I think I can see many use for a stack implemented like this.
Thanks for your work ! |
@johnr14 hey, glad that you like the feature. I already solved the problem of sorting the workspaces with a script, try and see if it does at least part of what you envision: https://gist.github.com/hariseldon78/d0b91e584fa97e3efcbd280cf1703f5f That said I'm not sure how much the main developer would agree to add too much complexity on the workspaces management, and if it's something that would fit better on a plugin we can use that tool. |
Wow, @hariseldon78 it's cleaver how you did it. I can't check it for the moment. I do hope workspace would get a stack like how the window does. As it would be easier to bind MOD+1 to be always be the first workspace on current monitor, no matter it's name or id. And it would be nice to move workspaces around on a monitor with something like MOD+CTRL+left|right. Scripting is great, but having a good dispatcher interface is mandatory to bring hyperwm to a general public. I am of those that doesn't have a lot time to spend on tuning my system, I need it to just work, but I want a good tiling manager and not a KDE|Gnome with a bunch of plugins. Thinking about how to go with your problem, I wrote #3805 as I found it hard to lookup information on the wiki. Thanks and I'll wait for the PR to be merged to upgrade to git with yay on arch. |
Describe your PR, what does it fix/add?
It allows to mark a workspace as persistent, inhibiting removal during the sanity check. Usage:
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
It's been decided to implement this feature as a workspace rule, after the conversation at #3346
Is it ready for merging, or does it need work?
Tested and ready for merging.
If it's welcome i could follow up with another PR for querying the workspace rules, I didn't find a command for that but I may be wrong.