Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): include version.h in PluginAPI.hpp #3571

Merged
merged 2 commits into from
Oct 15, 2023
Merged

fix(build): include version.h in PluginAPI.hpp #3571

merged 2 commits into from
Oct 15, 2023

Conversation

memchr
Copy link
Contributor

@memchr memchr commented Oct 14, 2023 •
edited
Loading

  • Include "version.h" in PluginAPI.hpp, otherwise meson or plugin build will fail.
  • Also, use [ -f ] to test files in Makefile instead of -d

@vaxerski
Copy link
Member

cnfl

vaxerski
vaxerski approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vaxerski vaxerski merged commit 43b39e0 into hyprwm:main Oct 15, 2023
11 checks passed
@horriblename horriblename mentioned this pull request Oct 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaxerski vaxerski vaxerski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@memchr @vaxerski