Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map cmake None to meson's plain #3717

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

q234rty
Copy link
Contributor

@q234rty q234rty commented Nov 1, 2023

Describe your PR, what does it fix/add?

empty is not a build type that exists in meson.

I have no idea why I typed "empty" in #3614 ...

Fixes: ba5f1d8

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Sorry, I thought I tested that change but apparently I didn't

Is it ready for merging, or does it need work?

Ready.

empty is not a build type that exists in meson.

I have no idea why I typed "empty" in hyprwm#3614 ...

Fixes: ba5f1d8
Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what this does/why it's required, but ok.

@fufexan fufexan merged commit ef90d1e into hyprwm:main Nov 2, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants