Map cmake None to meson empty #3614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While not explicitly mentioned by the cmake documentation, cmake upstream seems to think of None as a vaild CMAKE_BUILD_TYPE. [1] Handle it properly by mapping it to meson's empty. [1]: Kitware/CMake@ce1cadd
q234rty
added a commit
to q234rty/Hyprland
that referenced
this pull request
Nov 1, 2023
empty is not a build type that exists in meson. I have no idea why I typed "empty" in hyprwm#3614 ... Fixes: ba5f1d8
thejch
pushed a commit
to thejch/Hyprland
that referenced
this pull request
Nov 15, 2023
empty is not a build type that exists in meson. I have no idea why I typed "empty" in hyprwm#3614 ... Fixes: ba5f1d8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
While not explicitly mentioned by the cmake documentation, cmake upstream seems to think of None as a vaild CMAKE_BUILD_TYPE. Handle it properly by mapping it to meson's empty.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Not really.
Is it ready for merging, or does it need work?
Ready.