Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new feather for arg --ignore #13

Merged
merged 5 commits into from Oct 17, 2020

Conversation

tianlangwu
Copy link
Contributor

@tianlangwu tianlangwu commented Oct 16, 2020

Added the feather discussed in issue#12.
The test result shows below:
Ignore.txt contains all the URLs that test.txt have except the "s9y.org". The result will print only "s9y.org"
IGNORE1
Updated the README file for new arguments.
Please let me know if I did anything incorrectly, thanks!

Copy link
Owner

@hyunjiLeeTech hyunjiLeeTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
I've tested ignore.txt file editing to include 'http://s9y.org', but it doesn't work (I added a picture for it). Can you double-check whether it is working? If I am doing incorrectly, let me know.

@tianlangwu
Copy link
Contributor Author

It because the function is not synchronous, sometimes it might run the second readFile first. Because your readFile function is not synchronous, so I didn't make a synchronous read too.
let me try to make the synchronous function for both readFile.

@tianlangwu
Copy link
Contributor Author

tianlangwu commented Oct 16, 2020

Can you try it multiple times? Does it work most time? I believe it is sync problem but not sure.

I noticed that you are using global command url-fi, did you install the newest version? can u try "node index --ignored?

@hyunjiLeeTech
Copy link
Owner

hyunjiLeeTech commented Oct 16, 2020

I've installed a new version. When I tried it multiple times (with async), sometimes it works but sometimes not. The percentage is around 50%. But it is the same when I did not add async.

@tianlangwu
Copy link
Contributor Author

yes, we can't just add async. I believe there is more stuff to do to make the request async. I will give it a try later.

@hyunjiLeeTech
Copy link
Owner

Let me know when you've done. Thanks.

@tianlangwu
Copy link
Contributor Author

Can you try now?

@hyunjiLeeTech
Copy link
Owner

It almost works! However, when I add '#http://s9y.org' on the ignore.txt file, the program ignores this url too. Following our instruction, the line starts with # should be treated as comment. Can you take a look at this?

@tianlangwu
Copy link
Contributor Author

oh, I forget about # stuff, I will do it tomorrow. Thanks for reminding me that.

@tianlangwu
Copy link
Contributor Author

I fixed it, can you please check :D

@hyunjiLeeTech
Copy link
Owner

image
It seems only comment works. Can you double check it and tell me if I did incorrectly?

@tianlangwu
Copy link
Contributor Author

It works perfectly when I tested
ig01
ig02

@tianlangwu
Copy link
Contributor Author

are you on slack? we can discuss it there. You can send me your test file?

@hyunjiLeeTech
Copy link
Owner

Sure. I will send you my test file

@hyunjiLeeTech hyunjiLeeTech merged commit e8ea523 into hyunjiLeeTech:master Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants