This repository has been archived by the owner on Mar 17, 2022. It is now read-only.
Fix is_front_page() not working on WC shop page set as site's static front page #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…front page Not sure why this branch of IF conditional set post_type to 'product', since post_type is not set when using WooCommerce shop page as site's static front page. Removing this ELSE branch fix the issue and everything else is working fine. Tested with WooCommerce 3.1.2 and 3.2.1, switching default languages, using both shop page as site's front page and on standalone shop pages in all language versions.
|
@marian-kadanka Thank you 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #252
What's Included in This Pull Request
Not sure why this branch of IF conditional set post_type to 'product',
since post_type is not set when using WooCommerce shop page as site's
static front page. Removing this ELSE branch fix the issue and
everything else is working fine.
Tested with WooCommerce 3.1.2 and 3.2.1, switching default languages,
using both shop page as site's front page and on standalone shop
pages in all language versions.