Can't delete

[Jassper]

Anyway to add functionality to delete unwanted measurements?

[hzeller]

This isn't implemented yet. I accept pull requests hint hint :)

[Jassper]

I saw that in your readme file, but I'm new to Github, not sure how to do a pull request. But I'll try to figure it our.

Thanks

From: Henner Zeller [mailto:notifications@github.com]
Sent: Monday, December 30, 2013 12:55 PM
To: hzeller/augenmass
Cc: Jassper
Subject: Re: [augenmass] Can't delete (#1)

This isn't implemented yet. I accept pull requests hint hint :)

—
Reply to this email directly or view it on GitHub #1 (comment) .Image removed by sender.

[hzeller]

You essentially fork the code in git, make the needed changes and then ask back upstream to merge it (which is called 'pull request').

[Jassper]

Ahh, that's what I thought. But I'm not a programmer so I can't make the changes. Is there a way to 'request' a change?

From: Henner Zeller [mailto:notifications@github.com]
Sent: Monday, December 30, 2013 1:21 PM
To: hzeller/augenmass
Cc: Jassper
Subject: Re: [augenmass] Can't delete (#1)

You essentially fork the code in git, make the needed changes and then ask back upstream to merge it (which is called 'pull request').

—
Reply to this email directly or view it on GitHub #1 (comment) . https://github.com/notifications/beacon/5185134__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwMzk2MDQ1NCwiZGF0YSI6eyJpZCI6MjI3MzY0ODZ9fQ==--26f48e56aa843ba58d1fa487c1ee047b3045c24c.gif

[hzeller]

This is free software so it ultimately lives from people contributing code. Since I am busy with other stuff right now, I don't get around working on it right away, but it is certainly on my TODO list (and with your request got bumped a bit up). If you want to contribute in other ways than code, you could work out how you think it might look like (I think, it would require a separate mode 'select' which allows to select lines already drawn - so that it is possible to delete them with 'Del' or 'Backspace'). Having a good UI idea will help later implementation.

You could as well convince someone you know making such a change and then doing the pull request so that it is merged with upstream.

[Jassper]

OK, I'll check around my Makerspace and see if anyone knows Java well enough to make an attempt.

Thanks

From: Henner Zeller [mailto:notifications@github.com]
Sent: Monday, December 30, 2013 1:41 PM
To: hzeller/augenmass
Cc: Jassper
Subject: Re: [augenmass] Can't delete (#1)

This is free software so it ultimately lives from people contributing code. Since I am busy with other stuff right now, I don't get around working on it right away, but it is certainly on my TODO list (and with your request got bumped a bit up). If you want to contribute in other ways than code, you could work out how you think it might look like (I think, it would require a separate mode 'select' which allows to select lines already drawn - so that it is possible to delete them with 'Del' or 'Backspace'). Having a good UI idea will help later implementation.

You could as well convince someone you know making such a change and then doing the pull request so that it is merged with upstream.

—
Reply to this email directly or view it on GitHub #1 (comment) .Image removed by sender.

[hzeller]

Cool (Note, it is JavaScript though, entirely different)

[hzeller]

Fixed in PR #5