New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added command M181. #66
Conversation
lromor
commented
Apr 16, 2023
- Parser shall route to unprocessed commands.
- GCodeMachineControl shall handle the command and set the value to max if no S pair is provided. Added single test that only checks the motor ops queue shall be emptied before changing the planner size.
- Planner respect the lookahead value and always push older commands to maintain planning queue size. No tests added.
- Parser shall route to unprocessed commands. - GCodeMachineControl shall handle the command and set the value to max if no S<value> pair is provided. Added single test that only checks the motor ops queue shall be emptied before changing the planner size. - Planner respect the lookahead value and always push older commands to maintain planning queue size. No tests added.
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
==========================================
+ Coverage 45.93% 47.66% +1.72%
==========================================
Files 37 37
Lines 4245 4284 +39
==========================================
+ Hits 1950 2042 +92
+ Misses 2295 2242 -53
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of comments.
2e01679
to
16ac24c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the requested changes. Now working on a test for the planner.
@hzeller , I've added a planner test to check the lookahead resize behavior. Let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A line in the G-Code documentation would probably a good follow-up change.
In the |