Port python bindings to cython 3.0.x #1676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neuschaefer
force-pushed
the
cython
branch
5 times, most recently
from
e22e5e7
to
47d9c4d
Compare
There's no harm in running workflows on every branch/PR. It is, in fact useful, because contributors can see early when something is wrong.
cython 3.0 behaves a bit differently with regards to imports. It looks in bindings/python/ to find cppinc, but not in bindings/python/rgbmatrix. Fix this by importing directly from the current directory.
In cython 3.0, names with two underscores can't be used in derived classes. For more details refer to the Cython 3.0 migration guide: https://cython.readthedocs.io/en/latest/src/userguide/migrating_to_cy30.html
This fixes the following warning: warning: core.pyx:8:9: Only extern functions can throw C++ exceptions.
This fixes the following warning: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: /home/runner/work/rpi-rgb-led-matrix/rpi-rgb-led-matrix/bindings/python/rgbmatrix/core.pxd
|
Thanks! |
|
Ah, I see you/GitHub squashed this PR. I think that makes readability a bit worse in this case. Oh well :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are also some minor changes to the GitHub Actions workflow included. See the individual commit messages for details.