Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port python bindings to cython 3.0.x #1676

Merged
merged 8 commits into from
Jul 10, 2024
Merged

Port python bindings to cython 3.0.x #1676

merged 8 commits into from
Jul 10, 2024

Commits on Jul 9, 2024

  1. GitHub Actions: Test with different cython versions

    @neuschaefer
    neuschaefer committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    8a2c2fd View commit details
    Browse the repository at this point in the history

  2. GitHub Actions: Don't limit workflow runs to particular branches 

    There's no harm in running workflows on every branch/PR. It is, in fact
useful, because contributors can see early when something is wrong.
    @neuschaefer
    neuschaefer committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    edce418 View commit details
    Browse the repository at this point in the history

  3. bindings/python: Call make -C rgbmatrix, generate cython files if nec… 

    …essary
    @neuschaefer
    neuschaefer committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    7ec6401 View commit details
    Browse the repository at this point in the history

  4. bindings/python: Make imports more compatible 

    cython 3.0 behaves a bit differently with regards to imports. It looks
in bindings/python/ to find cppinc, but not in bindings/python/rgbmatrix.
Fix this by importing directly from the current directory.
    @neuschaefer
    neuschaefer committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    c754fb4 View commit details
    Browse the repository at this point in the history

  5. bindings/python: Change CYTHON default to cython3

    @neuschaefer
    neuschaefer committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    3b877bb View commit details
    Browse the repository at this point in the history

  6. bindings/python: Rename __getCanvas to _getCanvas for cython 3.0 compat 

    In cython 3.0, names with two underscores can't be used in derived
classes. For more details refer to the Cython 3.0 migration guide:

  https://cython.readthedocs.io/en/latest/src/userguide/migrating_to_cy30.html
    @neuschaefer
    neuschaefer committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    a53b420 View commit details
    Browse the repository at this point in the history

  7. bindings/python: Fix exception specifier 

    This fixes the following warning:

  warning: core.pyx:8:9: Only extern functions can throw C++ exceptions.
    @neuschaefer
    neuschaefer committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    5d0225c View commit details
    Browse the repository at this point in the history

  8. bindings/python: Explicitly set cython language_level=3str 

    This fixes the following warning:

  FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2).
  This will change in a later release!
  File: /home/runner/work/rpi-rgb-led-matrix/rpi-rgb-led-matrix/bindings/python/rgbmatrix/core.pxd
    @neuschaefer
    neuschaefer committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    73afd38 View commit details
    Browse the repository at this point in the history