Feature/Mark replaced holidays #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 23, 2020 15:26
Added holidayType, substitutedDay, and description to xsd.
Added WorkdayCacheData, changed cache to use CacheData, updated calculations, and tests accordingly.
Updated WorkdayDataReader to store new day descriptor information. Added HolidayType mapper for conversion between dto and cache data.
This was
linked to
issues
Jun 23, 2020
rombow
suggested changes
Jun 24, 2020
...ore-action/src/main/java/hu/icellmobilsoft/wdc/calculator/core/action/WorkdayDataReader.java
Outdated
Show resolved
Hide resolved
...ion/src/main/java/hu/icellmobilsoft/wdc/calculator/core/action/helper/HolidayTypeHelper.java
Show resolved
Hide resolved
...ion/src/main/java/hu/icellmobilsoft/wdc/calculator/core/action/helper/HolidayTypeHelper.java
Show resolved
Hide resolved
...ion/src/main/java/hu/icellmobilsoft/wdc/calculator/core/action/helper/HolidayTypeHelper.java
Show resolved
Hide resolved
rombow
previously approved these changes
Jun 24, 2020
vasizs
previously approved these changes
Jun 24, 2020
lutischan-ferenc
previously approved these changes
Jun 24, 2020
jhamrak
previously approved these changes
Jun 24, 2020
Also added commons.lang
magyari-adam
dismissed stale reviews from jhamrak, lutischan-ferenc, vasizs, and rombow
via
2732a42
vasizs
approved these changes
Jun 26, 2020
rombow
approved these changes
Jun 26, 2020
lutischan-ferenc
approved these changes
Jun 27, 2020
jhamrak
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.