add ECON1101 #106
Merged
add ECON1101 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you very much for your contribution! I'll review this PR in a few days. |
| "hours": "48", | ||
| "prerequisite": "无", | ||
| "evaluation": "20% homework + 15% quiz + 15% midterm + 50% final", | ||
| "teacher": [], |
There was a problem hiding this comment.
I've noticed that the instructor is Xiyi Yang and the TA is Dong Zhang. Is this correct? If you could confirm this info, I could fix the teacher and ta lists for you.
|
Sorry for replying so late, for I didn't frequently check my outlook.
The correct course code is ECON1101. I typed the wrong number at the beginning. I'm sorry for the mistake I had taken and the inconvenience I might bring to you.
发自 Outlook<http://aka.ms/weboutlook>
________________________________
发件人: Haoyi Wu ***@***.***>
发送时间: 2024年1月29日 19:14
收件人: i-TechX/iTechX ***@***.***>
抄送: TLNA114514 ***@***.***>; Author ***@***.***>
主题: Re: [i-TechX/iTechX] add ECON1101 (PR #106)
@why-in-Shanghaitech commented on this pull request.
________________________________
In courses/ECON1101/meta.json<#106 (comment)>:
@@ -0,0 +1,18 @@
+{
+ "code": "ECON1101",
Confirmed from LRC<https://lrc.shanghaitech.edu.cn/course-detail?course_id=1323082>, the course code ECON1101 is correct.
―
Reply to this email directly, view it on GitHub<#106 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BCY2DD2UI2Q7TZMTMAPAGQTYQ6ACNAVCNFSM6AAAAABCNAH2DWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNBYGQZDIOBUG4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
The names of the instructor and TA are right. Thank you for your correction！
发自 Outlook<http://aka.ms/weboutlook>
________________________________
发件人: Haoyi Wu ***@***.***>
发送时间: 2024年1月29日 19:10
收件人: i-TechX/iTechX ***@***.***>
抄送: TLNA114514 ***@***.***>; Author ***@***.***>
主题: Re: [i-TechX/iTechX] add ECON1101 (PR #106)
@why-in-Shanghaitech commented on this pull request.
Waiting for author response...
________________________________
In courses/ECON1101/meta.json<#106 (comment)>:
@@ -0,0 +1,18 @@
+{
+ "code": "ECON1101",
From the slides, I've noticed that the course code is ECON1001. Which one is correct?
________________________________
In courses/ECON1101/meta.json<#106 (comment)>:
@@ -0,0 +1,18 @@
+{
+ "code": "ECON1101",
+ "name": "Introduction to Economics: Energy and Environmental Economics\t",
+ "semesters": [
+ {
+ "season": "Fall",
+ "year": "2023",
+ "course_id": "ECON1101.01",
+ "department": "信息科学与技术学院",
+ "credit": "3",
+ "hours": "48",
+ "prerequisite": "无",
+ "evaluation": "20% homework + 15% quiz + 15% midterm + 50% final",
+ "teacher": [],
I've noticed that the instructor is Xiyi Yang and the TA is Dong Zhang. Is this correct? If you could confirm this info, I could fix the teacher and ta lists for you.
―
Reply to this email directly, view it on GitHub<#106 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BCY2DD7CZFASHRXOVFAZGYTYQ57TPAVCNFSM6AAAAABCNAH2DWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNBYGQYTEOBYGU>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
why-in-Shanghaitech
approved these changes
Jan 30, 2024
why-in-Shanghaitech
added a commit
that referenced
this pull request
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new course