Change version bounds to fix nixpkgs build #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lovely! Thanks very much :) |
|
@markus1189 you'll have to help me, I'm pretty ignorant here; do I need to do a new hackage release, or is this all you need? |
|
@i-am-tom I would need a new release :) Was just coming here to say that, somehow I did not see your question 😅 |
|
Friendly post christmas ping :) A new release would be great 😄 |
|
Hello! Awesome, I'll do that now :D |
|
@markus1189 New version (0.3.2.0) should be uploaded now - hopefully everything works 🤞 Thanks for the nudge! I'll leave this open just in case I've messed something up 😄 |
|
Awesome, thanks! |
markus1189
added a commit
to markus1189/nixpkgs
that referenced
this pull request
Jan 5, 2021
Thanks to i-am-tom/holmes#15 `holmes` now builds successfully 🎉
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the latest nixpkgs version,
holmesfails to build, because it does not allowrelude-0.7.*.*andbase-4.14.1.0.I bumped the bounds and checked locally that it builds + tests are green