Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added keywords to routing #626

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Added keywords to routing #626

merged 2 commits into from
Jun 21, 2024

Conversation

wpfl-dbt
Copy link
Collaborator

@wpfl-dbt wpfl-dbt commented Jun 20, 2024

Context

See REDBOX-398. We want to be able to manually select a route using a @keyword syntax.

Changes proposed in this pull request

  • Adds a regex layer to detect @keywords by route name.

Guidance to review

  • Check tests run
  • Check implementation

Things to check

Copy link
Collaborator

@lmwilkigov lmwilkigov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very tidy 🙌

@wpfl-dbt wpfl-dbt merged commit 5ab2064 into main Jun 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants