Provide Search GraphQL Interfaces #150
Conversation
search/domain/service.go
Outdated
| SelectedDesc bool | ||
| // Asc - DEPRECATED - used to give the "Field" that is used to trigger ascending search |
There was a problem hiding this comment.
Maybe document the deprecation like: https://github.com/golang/go/wiki/Deprecated
The field seems completely unused. Could this potentially lead to undesired behavior for library consumers since the value is ignored? (same for Desc)
There was a problem hiding this comment.
I updated the deprecated fields. Which fields do you mean? Field or Asc/Desc? We left Asc/Desc there because we weren't sure if we introduce a breaking change if we remove them completely. In case of Field. We are using it for the graphql part and it is used in flamingo-om3 which is in the other merge request.
There was a problem hiding this comment.
@danielpoe could both fields ( Asc, Desc) actually be deleted? this looks quite like dead code.
There was a problem hiding this comment.
How do you know they are not used??
They are part of the public API - projects depend on it and its also filled in the Adapters currently
@panzerfahrer
There was a problem hiding this comment.
The team decided to deprecate the field. If the fields are actually in use, we should probably add fallback behavior. Or do we need a rollback with another solution?
There was a problem hiding this comment.
... @kalypso-byte could you please clarify, whether the deprecation was a valid move.
There was a problem hiding this comment.
The DEPRECATED is valid we did this together. - but because the intent of this property is wrong (it represents the fieldname for searchperience) we want to remove it in future
We just need time to adjust the current usage
There was a problem hiding this comment.
So all is fine at the moment - just wanted to clarify
| SelectedDesc bool | ||
| // Asc - represents the field that is used to trigger ascending search. | ||
| // Deprecated: use "Field" and "SelectedAsc" instead to set which field should be sortable |
There was a problem hiding this comment.
The message is wrong
It should say: Use "Field" to know which Field to set in the SortFilter
No description provided.