-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(zap): silent zap logging #308
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanMaidurov
force-pushed
the
feature/silent_zap_logging
branch
6 times, most recently
from
December 16, 2022 16:08
493d7f8
to
02381b1
Compare
easy test with no parallel requests but with parallel writings:
100 parallel requests, each. with 300 parallel writes:
|
bastianccm
requested changes
Jan 19, 2023
IvanMaidurov
force-pushed
the
feature/silent_zap_logging
branch
from
March 21, 2023 14:44
02381b1
to
eb3bccd
Compare
bastianccm
approved these changes
Mar 24, 2023
bastianccm
force-pushed
the
feature/silent_zap_logging
branch
from
March 24, 2023 08:46
3a1720c
to
396e8fc
Compare
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logger will write to output only if error occurred during request
Closes #311