feat(core/auth/oauth): Add optional OIDC callback error handler #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases you want to handle errors that happen during the OIDC callback differently. A use case could be authenticating the user using the `prompt=none` flow which can result in a `error=login_required` on the Callback endpoint if the user is not already signed in with the identity provider. In this case you might want to redirect the user or display a specific error page. The handler is optional and if it can't handle the error the build in logic kicks in.
|
bastianccm
approved these changes
Jan 19, 2023
bastianccm
deleted the
feature/oidc-add-optional-callback-error-handler
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases you want to handle errors that happen during the OIDC callback differently.
A use case could be authenticating the user using the
prompt=noneflow which can result in aerror=login_requiredon the Callback endpoint if the user is not already signed in with the identity provider. In this case you might want to redirect the user or display a specific error page.The handler is optional and if it can't handle the error the build in logic kicks in.