feat(oidc): Make state timeout duration configurable to support long taking sign in #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tessig
reviewed
Oct 18, 2023
core/auth/oauth/oidc.go
Outdated
| stateTimeout := defaultStateTimeout | ||
|
|
||
| if oidcConfig.StateLifeTime != "" { | ||
| if duration, err := time.ParseDuration(oidcConfig.StateLifeTime); err == nil { |
There was a problem hiding this comment.
I would prefer a user feedback on wrongly configured duration instead of silent fallback to default
|
tessig
approved these changes
Oct 18, 2023
carstendietrich
deleted the
feat/oidc-make-state-lifetime-configurable
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default we invalidate all state params that are older than 30min, this means if you spent 30min on the login page of the identity provider and then came back to flamingo you would be greeted by a lovely state mismatch error.
Reasons for spending such a long time at the OIDC provider could be for example creating a new account with various verification steps.
Introducing a config to support long-running login/registrations. If not specified we'll stick to 30min.