Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create new auth module #50

Merged
merged 25 commits into from
Jan 28, 2020
Merged

create new auth module #50

merged 25 commits into from
Jan 28, 2020

Conversation

bastianccm
Copy link
Contributor

As discussed some time ago, the interfaces and a HTTP Basic Auth example for a possible integration

@bastianccm bastianccm added the enhancement New feature or request label Jul 23, 2019
Copy link
Member

@danielpoe danielpoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we DEPRICATE the oauth module hen and provide a standalone "oauth" module in flamingo root that uses the new interfaces?

core/auth/identifier.go Outdated Show resolved Hide resolved
@danielpoe
Copy link
Member

What did we discuss about adjusting security module?

At least we should also add a role provider that is using the configured idendity - so that security module works out of the box

@danielpoe
Copy link
Member

The basic auth example cannot be used out of the box - since the "authenticate" part is missing where we send the header that makes the browser open the user/pw dialog.

Maybe we should then move the basicauth stuff to own module and provide also controller for this that gets redirect url to redirect to after sucessful authentication.. This way it acts as a "full" but easy example

@danielpoe
Copy link
Member

We should also add a Readme, explaining how the module can be used (check Idendity) and how to implement own Idendificators

The docu should also explain the more advances usage of the security module in combination with auth - to protect actions by either:

  • wrap in bindings or
  • explicit call role provider

core/auth/identity.go Show resolved Hide resolved
core/auth/webidentity.go Outdated Show resolved Hide resolved
core/auth/identifier.go Outdated Show resolved Hide resolved
core/auth/controller.go Outdated Show resolved Hide resolved
core/auth/controller.go Outdated Show resolved Hide resolved
core/auth/webidentity.go Outdated Show resolved Hide resolved
core/auth/webidentity.go Show resolved Hide resolved
core/auth/module.go Outdated Show resolved Hide resolved
core/auth/module.go Outdated Show resolved Hide resolved
core/auth/module.go Outdated Show resolved Hide resolved
core/auth/module.go Outdated Show resolved Hide resolved
core/auth/http/http.go Outdated Show resolved Hide resolved
core/auth/oauth/oidc.go Show resolved Hide resolved
@bastianccm bastianccm changed the title WIP: create a basic auth layer which is able to identify incoming requests create new auth module Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants