Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cookieOptions for setting cookies #203

Merged
merged 1 commit into from
Apr 16, 2020
Merged

feat: add cookieOptions for setting cookies #203

merged 1 commit into from
Apr 16, 2020

Conversation

michielmetcake
Copy link
Contributor

I need this feature to set cookies to same-site and secure. Could you check my PR?

@jamuhl
Copy link
Member

jamuhl commented Apr 16, 2020

could you please cleanup your PR to not include code style changes...containing only the changes in source...thank you

@michielmetcake
Copy link
Contributor Author

I've cleaned it up a little bit. thanks

@jamuhl jamuhl merged commit 058b4c4 into i18next:master Apr 16, 2020
@jamuhl
Copy link
Member

jamuhl commented Apr 16, 2020

published in i18next-browser-languagedetector@4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants