Fix extracting Trans component without key, but with default value #871
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again! Just wanted to thank you for maintaining this project, and for responding so quick to my other PRs.
Why am I submitting this PR
This PR fixes a bug that causes us to extract the keys of Trans components with default values incorrectly.
Take the following example:
The above results in the key
{{name}}
, which is correct. However, if we add a default value, it causes us to extract the key incorrectly:The above results in a key of
Steve
, which isn't correct. The key shouldn't change when we provide a default value.Does it fix an existing ticket?
Possibly fixes #249, but I'm not sure if this is the same issue that the user was describing.
Checklist
yarn test
(see details here)