add isInitializing property #2141

i18next · Feb 22, 2024 · a19c141 · a19c141
1 parent f66289e
commit a19c141
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 23.10.0
+
+- Add 'isInitializing' property so we're able to detect init() was already called [2141](https://github.com/i18next/i18next/issues/2141)
+
 ## 23.9.0
 
 - types: support nested keys in `InterpolationMap` [2140](https://github.com/i18next/i18next/pull/2140) fixes [2014](https://github.com/i18next/i18next/issues/2014)

diff --git a/i18next.js b/i18next.js
@@ -1916,6 +1916,7 @@
       var _this = this;
       let options = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {};
       let callback = arguments.length > 1 ? arguments[1] : undefined;
+      this.isInitializing = true;
       if (typeof options === 'function') {
         callback = options;
         options = {};
@@ -2033,6 +2034,7 @@
       const deferred = defer();
       const load = () => {
         const finish = (err, t) => {
+          this.isInitializing = false;
           if (this.isInitialized && !this.initializedStoreOnce) this.logger.warn('init: i18next is already initialized. You should call init just once!');
           this.isInitialized = true;
           if (!this.options.isClone) this.logger.log('initialized', this.options);

diff --git a/i18next.min.js b/i18next.min.js
diff --git a/index.d.ts b/index.d.ts
@@ -502,6 +502,11 @@ export interface i18n extends CustomInstanceExtensions {
    */
   isInitialized: boolean;
 
+  /**
+   * Is initializing
+   */
+  isInitializing: boolean;
+
   /**
    * Store was initialized
    */

diff --git a/src/i18next.js b/src/i18next.js
@@ -48,6 +48,7 @@ class I18n extends EventEmitter {
   }
 
   init(options = {}, callback) {
+    this.isInitializing = true;
     if (typeof options === 'function') {
       callback = options;
       options = {};
@@ -189,6 +190,7 @@ class I18n extends EventEmitter {
 
     const load = () => {
       const finish = (err, t) => {
+        this.isInitializing = false;
         if (this.isInitialized && !this.initializedStoreOnce) this.logger.warn('init: i18next is already initialized. You should call init just once!');
         this.isInitialized = true;
         if (!this.options.isClone) this.logger.log('initialized', this.options);

diff --git a/test/runtime/i18next.hasLoadedNamespace.test.js b/test/runtime/i18next.hasLoadedNamespace.test.js
@@ -69,7 +69,13 @@ describe('i18next', () => {
 
     describe('called init() not detecting lng', () => {
       it('it should ok - but warn about issue', async () => {
-        await i18n.init({ debug: true, saveMissing: true });
+        expect(i18n.isInitialized).toBeFalsy();
+        expect(i18n.isInitializing).toBeFalsy();
+        const prom = i18n.init({ debug: true, saveMissing: true });
+        expect(i18n.isInitializing).toBeTruthy();
+        expect(i18n.isInitialized).toBeFalsy();
+        await prom;
+        expect(i18n.isInitializing).toBeFalsy();
         expect(i18n.isInitialized).toBeTruthy();
 
         expect(i18n.hasLoadedNamespace('translation')).to.equal(false);