context can also be a number, fixes #1622

i18next · Jun 17, 2021 · d304941 · d304941
1 parent 2482b61
commit d304941
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+### 20.3.2
+
+- context can also be a number [1622](https://github.com/i18next/i18next/issues/1622)
+
 ### 20.3.1
 
 - add 'ns' to the 'returnedObjectHandler' options [1619](https://github.com/i18next/i18next/pull/1619)

diff --git a/i18next.js b/i18next.js
@@ -919,7 +919,7 @@
           var namespaces = extracted.namespaces;
           if (_this4.options.fallbackNS) namespaces = namespaces.concat(_this4.options.fallbackNS);
           var needsPluralHandling = options.count !== undefined && typeof options.count !== 'string';
-          var needsContextHandling = options.context !== undefined && typeof options.context === 'string' && options.context !== '';
+          var needsContextHandling = options.context !== undefined && (typeof options.context === 'string' || typeof options.context === 'number') && options.context !== '';
           var codes = options.lngs ? options.lngs : _this4.languageUtils.toResolveHierarchy(options.lng || _this4.language, options.fallbackLng);
           namespaces.forEach(function (ns) {
             if (_this4.isValidLookup(found)) return;

diff --git a/i18next.min.js b/i18next.min.js
diff --git a/src/Translator.js b/src/Translator.js
@@ -378,7 +378,7 @@ class Translator extends EventEmitter {
       const needsPluralHandling = options.count !== undefined && typeof options.count !== 'string';
       const needsContextHandling =
         options.context !== undefined &&
-        typeof options.context === 'string' &&
+        (typeof options.context === 'string' || typeof options.context === 'number') &&
         options.context !== '';
 
       const codes = options.lngs

diff --git a/test/translator/translator.translate.context.spec.js b/test/translator/translator.translate.context.spec.js
@@ -15,13 +15,15 @@ describe('Translator', () => {
             test: 'test_en',
             test_male: 'test_male_en',
             test_female: 'test_female_en',
+            test_1: 'test_one_en',
           },
         },
         de: {
           translation: {
             test: 'test_de',
             test_male: 'test_male_de',
             test_female: 'test_female_de',
+            test_1: 'test_one_de',
           },
         },
       });
@@ -71,6 +73,22 @@ describe('Translator', () => {
         args: ['translation:test', { context: 'female', lng: 'en-US' }],
         expected: 'test_female_en',
       },
+      {
+        args: ['translation:test', { context: '1', lng: 'en-US' }],
+        expected: 'test_one_en',
+      },
+      {
+        args: ['translation:test', { context: '1', lng: 'de' }],
+        expected: 'test_one_de',
+      },
+      {
+        args: ['translation:test', { context: 1, lng: 'en-US' }],
+        expected: 'test_one_en',
+      },
+      {
+        args: ['translation:test', { context: 1, lng: 'de' }],
+        expected: 'test_one_de',
+      },
     ];
 
     tests.forEach(test => {