Missing key default pluralization issues

[namoscato]

🐛 Bug Report

There seems to be some issues with default value pluralization when missingKeys is enabled:

1. The result of interpolation is incorrect and does not seem to respect pluralization
2. The singular and plural values passed to the backend, when configured, are the same

To Reproduce

Here's a CodeSandbox that illustrates the issue when evaluating:

t("myMissingKey", {
    count,
    defaultValue: "{{ count }} word",
    defaultValue_plural: "{{ count }} words"
})

This is not an issue when saveMissing=false.

Expected behavior

Per the defaultValue description:

you also can define defaults for plurals by adding defaultValue_plural / defaultValue_2 -> _suffix depends on same pluralrules

I would expect the myMissingKey string to be pluralized correctly as count changes, and the missing key handler configured via a backend, should receive:

{
    "myMissingKey": "{{ count }} word",
    "myMissingKey_plural": "{{ count }} words"
}

Your Environment

• runtime version: Chrome v88
• i18next version: v19.8.7
• react-i18next version: v11.8.5
• i18next-locize-backend version: v4.1.9
• os: macOS

[adrai]

This is probably, because your first count value is 0, and this is a plural

[namoscato]

Yeah, makes sense – if the state is initialized to 1, it's always singular.

With that said, is this expected behavior?

[adrai]

seems so

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[namoscato]

Working with this some more over the past week, this still seems like a minor bug to me.

I'm happy to help out with a fix, but it might be a few weeks before I get around to it; feel free to point me in the right direction of the relevant code in the meantime.

[jamuhl]

@namoscato that functionality can be found here https://github.com/i18next/i18next/blob/master/src/Translator.js#L245

would be happy to accept a PR

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[namoscato]

FYI, I took a pass at this in #1558.