Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to always format interpolated values #1385

Merged
merged 4 commits into from Jan 24, 2020

Conversation

mjbcopland
Copy link
Contributor

Addresses #1384

Although there isn't a compelling reason to be dependent on the old behaviour, this is technically a breaking change so I've added a new option alwaysFormat (not sure if this should also update the docs) which will, unimaginatively, always format values used for interpolation. This option defaults to false in order to preserve existing behaviour.

@coveralls
Copy link

coveralls commented Jan 22, 2020

Coverage Status

Coverage increased (+0.01%) to 93.34% when pulling 5fec9a8 on mjbcopland:feature/always-format into ca38b44 on i18next:master.

@jamuhl jamuhl merged commit 5375490 into i18next:master Jan 24, 2020
@jamuhl
Copy link
Member

jamuhl commented Jan 24, 2020

Will be published this weekend....

@jamuhl
Copy link
Member

jamuhl commented Jan 27, 2020

landed in i18next@19.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants