Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a plural resolver for locale "ht" #1492

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Add a plural resolver for locale "ht" #1492

merged 1 commit into from
Jul 21, 2020

Conversation

marcja
Copy link
Contributor

@marcja marcja commented Jul 18, 2020

Fix #1491

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • documentation is changed or added

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.941% when pulling d582c31 on marcja:patch-1 into b8b014f on i18next:master.

@jamuhl
Copy link
Member

jamuhl commented Jul 19, 2020

ht can't be found in the official https://unicode-org.github.io/cldr-staging/charts/37/supplemental/language_plural_rules.html#ht what is the language called (guess it's Haiti)?

@marcja
Copy link
Contributor Author

marcja commented Jul 20, 2020

Yes, Haitian Creole. It's a required locale for a project I'm working on.

@jamuhl jamuhl merged commit 88460a8 into i18next:master Jul 21, 2020
@jamuhl
Copy link
Member

jamuhl commented Jul 21, 2020

Will be deployed with the next version...hope that is ok for you?

If needing it now, you can add rules using i18next.services.pluralResolver.addRule meanwhile...https://github.com/i18next/i18next/blob/master/src/PluralResolver.js#L90

@marcja
Copy link
Contributor Author

marcja commented Jul 21, 2020

Awesome. Thanks!

@marcja marcja deleted the patch-1 branch July 21, 2020 21:03
@adrai
Copy link
Member

adrai commented Jul 24, 2020

released with v19.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Locale "ht" is missing from PluralResolver.js
4 participants