Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1618 - Add 'ns' to the 'returnedObjectHandler' options #1619

Merged
merged 2 commits into from May 28, 2021
Merged

1618 - Add 'ns' to the 'returnedObjectHandler' options #1619

merged 2 commits into from May 28, 2021

Conversation

miguelCT
Copy link
Contributor

Add 'ns' to the 'returnedObjectHandler' options

I've used the same base code from #1617 to add tests for the returnObject = false case

closes #1618

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • documentation is changed or added

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 93.197% when pulling ad90286 on miguelCT:1618-fix-ns-in-returnedObjectHandler into 44c9e58 on i18next:master.

@jamuhl jamuhl requested a review from adrai May 28, 2021 06:54
@jamuhl
Copy link
Member

jamuhl commented May 28, 2021

lgtm

@adrai adrai merged commit 20f9ce2 into i18next:master May 28, 2021
@adrai adrai mentioned this pull request May 28, 2021
Closed
4 tasks
@adrai
Copy link
Member

adrai commented May 28, 2021

released with v20.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrai adrai adrai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The namespace from the translated key is lost when using "returnedObjectHandler"
4 participants
@miguelCT @coveralls @jamuhl @adrai