Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-1703 #1704

Merged
merged 1 commit into from
Dec 7, 2021
Merged

fix-1703 #1704

merged 1 commit into from
Dec 7, 2021

Conversation

hon2a
Copy link
Contributor

@hon2a hon2a commented Dec 7, 2021

Fixed Translator to supply correct defaults for plural forms (if supplied) to saveMissing. (Fixes #1703 .)

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included (or rather the existing test is modified)

@hon2a
Copy link
Contributor Author

hon2a commented Dec 7, 2021

The failed CodeClimate check has nothing to do with this patch (it's on unchanged code).

@adrai adrai merged commit c4f2248 into i18next:master Dec 7, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 90.884% when pulling f06c571 on hon2a:hon2a/missing-defaults-plural into 34c5efd on i18next:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defaultValues of pluralized messages are not being sent to missingKeyHandler properly
3 participants